chore(@kadena/react-ui): Removed "background" from sprinkles properties #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmguo
requested review from
sstraatemans,
salamaashoush,
sanderlooijenga,
KristinaSpasevska and
realdreamer
as code owners
🦋 Changeset detectedLatest commit: ca3996d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
sanderlooijenga
approved these changes
Nov 8, 2023
ferreroltd
approved these changes
Nov 9, 2023
eileenmguo
force-pushed
the
chore/background-sprinkles-cleanup
branch
2 times, most recently
from
d4b4826 to
47835b8
Compare
salamaashoush
approved these changes
Nov 20, 2023
eileenmguo
force-pushed
the
chore/background-sprinkles-cleanup
branch
from
47835b8 to
ca3996d
Compare
sstraatemans
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had background and backgroundColor in our sprinkles properties which means we were creating double the utility classes for giving the background of a component a color from the design system. I've removed "background" and replaced all usage with "backgroundColor" since most people seemed to prefer that attribute more.