Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kadena/graph-client] Account page Guard and styling fixes #1207

Merged
merged 16 commits into from
Nov 15, 2023

Conversation

MRVDH
Copy link
Contributor

@MRVDH MRVDH commented Nov 9, 2023

No description provided.

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: b0939e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@kadena/graph Patch
@kadena/graph-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:09pm
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:09pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:09pm
tools ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:09pm

@MRVDH MRVDH marked this pull request as draft November 9, 2023 15:00
@MRVDH MRVDH marked this pull request as ready for review November 10, 2023 08:27
@nil-amrutlal
Copy link
Contributor

nil-amrutlal commented Nov 10, 2023

Some things I noticed by browsing around, so I am not sure if these were like this purposefully
The blocks are not centered in the screen
image

The same goes for error messages and for the loader component when data is loading
image
image

@nil-amrutlal
Copy link
Contributor

No loader component when loading the blocks on the main page
image

Copy link
Contributor

@nil-amrutlal nil-amrutlal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just waiting for the failing build to pass and also to confirm whether uncentered blocks, loaders, and error messages were purposeful or not

@nil-amrutlal nil-amrutlal merged commit a6bf444 into main Nov 15, 2023
12 checks passed
@nil-amrutlal nil-amrutlal deleted the feat/graph/guard-account-page-and-styling-fixes branch November 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants