Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@kadena/react-ui): Update documentation and storybook #1389

Merged
merged 9 commits into from
Jan 23, 2024

Conversation

eileenmguo
Copy link
Contributor

@eileenmguo eileenmguo commented Dec 22, 2023

  • Updated the README.md and CONTRIBUTING.md to reflect the decisions the team has made.
  • Hid some of the input stories that we are deprecating for a cleaner side menu.
  • Updated the component statuses to be reflective of the current state of components

Copy link

changeset-bot bot commented Dec 22, 2023

🦋 Changeset detected

Latest commit: 462ed32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview Jan 23, 2024 2:52pm
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 2:52pm
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 2:52pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 2:52pm
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 2:52pm

@eileenmguo eileenmguo force-pushed the chore/update-react-ui-documentation branch from 1926aa5 to e20a236 Compare January 23, 2024 14:33
```jsonc
<Button icon="someIcon" iconAlign="right" loading={false}>Label</Button>
```tsx
<Button startIcon="someIcon" loading={false}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button startIcon="someIcon" loading={false}>
<Button startIcon="someIcon" isLoading={false}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! missed this. I will update it in a separate PR

@eileenmguo eileenmguo merged commit 9f7c650 into main Jan 23, 2024
17 of 18 checks passed
@eileenmguo eileenmguo deleted the chore/update-react-ui-documentation branch January 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants