chore(@kadena/react-ui): Cleanup NavHeader and incorporate into the Docs website #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eileenmguo
commented
Jan 19, 2024
•
eileenmguo
commented
- Updated the NavHeader component to export all subcomponents as separate components
- Updated the NavHeader compound components to use existing UI components (ex button, select)
- Updated the Docs website to use the new NavHeader components for consistency
🦋 Changeset detectedLatest commit: 25eddc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
eileenmguo
force-pushed
the
chore/nav-header
branch
from
379b048 to
a721e73
Compare
eileenmguo
force-pushed
the
chore/nav-header
branch
from
a721e73 to
4deadfd
Compare
eileenmguo
requested review from
sstraatemans,
salamaashoush,
sanderlooijenga,
KristinaSpasevska,
realdreamer and
Ghislain89
as code owners
| <NavHeader | ||
| logo={ | ||
| <Link href={'/'}> | ||
| <Logo /> |
There was a problem hiding this comment.
We used to have two logos for smaller/larger screens, so this isn't the case anymore?
There was a problem hiding this comment.
That was unintentional! I will fix it 👍
|
Also to double check, will the glow be removed from the Header? |
Yes, the new branding does not have any glow |
KristinaSpasevska
approved these changes
Jan 26, 2024
salamaashoush
approved these changes
Feb 1, 2024
eileenmguo
force-pushed
the
chore/nav-header
branch
from
ee84f50 to
9fe051e
Compare
sstraatemans
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.