-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Snaps README to include RPC documentation #2561
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 7 Skipped Deployments
|
|
||
### kda_signTransaction | ||
|
||
**Description**: Signs a transaction using the Kadena Snap. The transaction is expected to be a stringified JSON of the type [`ICommandPayload`](https://github.com/kadena-community/kadena.js/blob/f88301538ee41b77b957edf58a8a5edb4fba44cb/packages/libs/types/src/PactCommand.ts#L176). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure where to fine a more permanent documentation link for ICommandPayload
.
I derived that the expected request type was this from the following areas of the code:
txn = JSON.parse(transaction); const signerEntries = getSignerEntries(txn, publicKey); txnRequest: ICommandPayload,
But would appreciate it if someone else could verify as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we discussed, IPactCommand is more current
@LindaOrtega can we update the linting and get this merged? |
… snaps repo
Add RPC documentation to Snaps README
Short description:
Restructure the README of the snaps library to provide more information on what RPC methods are available with MetaMask Snap and how to use them.
Besides some minor re-structuring and re-wording, this content was copied over from another repository and was originally created by @nillo.
Test scenarios