Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dw): transaction page improvement #2730

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat(dw): transaction page improvement #2730

merged 3 commits into from
Dec 11, 2024

Conversation

javadkh2
Copy link
Collaborator

Modify this title

Related Issue/Asana ticket: _

Short description: _

Test scenarios

  • description of the (manually) executed test scenarios

Reminders (if applicable)

  • I ran pnpm install and pnpm test in the root of the monorepo
    (optionally with --filter=...package... to exclude non-affected
    projects)
  • I ran pnpm changeset in the root of the monorepo
  • Test coverage has not decreased
  • Docs have been updated to reflect changes in PR (don't forget
    docs.kadena.io)

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 7dd38b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:38pm
rwa-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:38pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:38pm
kode-ui ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 5:38pm
explorer ⬜️ Skipped (Inspect) Dec 11, 2024 5:38pm
marmalade-marketplace ⬜️ Skipped (Inspect) Dec 11, 2024 5:38pm
proof-of-us ⬜️ Skipped (Inspect) Dec 11, 2024 5:38pm
tools ⬜️ Skipped (Inspect) Dec 11, 2024 5:38pm

const dd = twoDigitPad(date.getDate());
const hh = twoDigitPad(date.getHours());
const min = twoDigitPad(date.getMinutes());
return `${year}-${mm}-${dd}T${hh}:${min}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't include timezone right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there was a bug in the previous code so it showed different time

@vercel vercel bot temporarily deployed to Preview – explorer December 11, 2024 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace December 11, 2024 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us December 11, 2024 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – tools December 11, 2024 17:35 Inactive
@javadkh2 javadkh2 merged commit 5175973 into main Dec 11, 2024
21 checks passed
@javadkh2 javadkh2 deleted the feat/transaction-page branch December 11, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants