Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PactDB Compaction #1680

Merged
merged 85 commits into from
Nov 16, 2023
Merged

PactDB Compaction #1680

merged 85 commits into from
Nov 16, 2023

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Jun 13, 2023

No description provided.

@chessai chessai force-pushed the chessai/compaction branch from c0b2fc3 to 9160de6 Compare July 10, 2023 22:31
larskuhtz and others added 29 commits July 11, 2023 10:31
@larskuhtz @chessai
PactDB: compute sha3 checksums
7994f59
@sirlensalot @chessai
fix build
3eb1f48
@sirlensalot @chessai
compact system tables
31eebfa
@sirlensalot @chessai
refactor
33d5884
@sirlensalot @chessai
docs
f5714ba
@sirlensalot @chessai
test verifies hashes
106db3f
@sirlensalot @chessai
return global hash
a6c1682
@sirlensalot @chessai
dedicated test
b90251c
@sirlensalot @chessai
Code-complete with cw-tool
27e6329
@sirlensalot @chessai
test comments
21d4385
@sirlensalot @chessai
cleanup sql
8a063c5
@sirlensalot @chessai
cleanup
2282f20
@sirlensalot @chessai
cleanup
0a65092
@sirlensalot @chessai
fix build
59e9934
@sirlensalot @chessai
Hashing no longer in checkpointer, internal to compaction
614baeb
@sirlensalot @chessai
cleanup
cc7198e
@sirlensalot @chessai
fix drop table, add vacuum
d4b8bde
@sirlensalot @chessai
test TODOs
ecbfd3e
@chessai
optparse cleanups
f123fe6
@chessai
remove flag addition in chainweb.cabal
4b8a48d
@chessai
clean up imports
b7c701f
@chessai
make relevant fields strict
0269ed1
@chessai
minor src cleanups
870db50
@chessai
add some docs to compaction functions
0ddb865
@chessai
first test stuff
0f5f38c
@chessai
more compaction haddocks/add blockheight to invalid block height exce…
5f97870 
…ption
@chessai
remove redundant import
559101e
@chessai
add flag to not drop new tables
a232790
@chessai
compact concurrently, add log directory for per-chain logs
e4d1a29
thoughtpolice
thoughtpolice reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a first pass, we'll go over it again shortly!

src/Chainweb/Pact/PactService/Checkpointer.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/PactService/Checkpointer.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/MultiNode.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Compaction.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Compaction.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
edmundnoble
edmundnoble reviewed Nov 15, 2023
View reviewed changes
src/Chainweb/Pact/PactService.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/PactService/Checkpointer.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Service/Types.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
edmundnoble
edmundnoble reviewed Nov 15, 2023
View reviewed changes
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
edmundnoble
edmundnoble approved these changes Nov 16, 2023
View reviewed changes
src/Chainweb/Pact/Backend/Compaction.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/PactSingleChainTest.hs Outdated Show resolved Hide resolved
@chessai chessai added this pull request to the merge queue Nov 16, 2023
Merged via the queue into master with commit 5dbc7da Nov 16, 2023
38 of 39 checks passed
@ghost ghost deleted the chessai/compaction branch March 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice left review comments

@edmundnoble edmundnoble edmundnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chessai @thoughtpolice @edmundnoble @larskuhtz @sirlensalot