Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compaction: a couple of minor bug fixes #1781

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Nov 17, 2023

  • only flush the logger handle if it's open. the flushing thread will throw an exception. this doesn't actually cause any issues, we just don't need to perform the flush if the handle is no longer open, and it prints some unnecessary/silly error messages to stderr.
  • don't redundantly log the initial query to grab the latest block height on chain 0. this is confusing to look at, because users see the logs coming, and then nothing further.

@chessai chessai requested a review from edmundnoble November 17, 2023 23:05
@chessai chessai added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2023
@chessai chessai added this pull request to the merge queue Nov 18, 2023
Merged via the queue into master with commit 56b5215 Nov 18, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants