miscelaneous small changes #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
reviewed
Jan 3, 2025
Comment on lines
+274
to
+275
| -- TODO: Shouldn't this type guarantee that the map is total, i.e. that there | ||
| -- exists a value for each chain? |
There was a problem hiding this comment.
Hmmmmm... maybe we can do this, yes. Please leave this comment here.
Comment on lines
+314
to
+319
|
|
||
| type instance Index (ChainMap a) = ChainId | ||
| type instance IxValue (ChainMap a) = a | ||
|
|
||
| instance IxedGet (ChainMap a) where | ||
| ixg i = atChain i |
There was a problem hiding this comment.
We should probably even have an Ixed instance.
| @@ -29,7 +29,6 @@ module Chainweb.BlockHeaderDB.Internal | |||
| ( | |||
| -- * Internal Types | |||
| RankedBlockHeader(..) | |||
There was a problem hiding this comment.
Do we still need RankedBlockHeader with the Ranked newtype? I suppose if we make it wrap a Ranked BlockHeader, that will waste some memory by duplicating the height.
There was a problem hiding this comment.
Yeah, that's the reasoning for not using Ranked with BlockHeader.
edmundnoble
previously approved these changes
Jan 3, 2025
There was a problem hiding this comment.
I see that this:
- adds a
Rankedtype, which should be able to replace a couple newtypes like forRankedBlockHash. - adds some extra instances for
ChainMapand a salient comment. - splits
BlockPayloadHashinto its own file - of course this is required by EVM. - adds some other utilities and missing instances.
Co-authored-by: chessai <[email protected]> Co-authored-by: Edmund Noble <[email protected]>
miner rewards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small unrelated changes. It is easiest to review on a per commit basis.