Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miscellaneous small changes #2090

Merged
merged 8 commits into from
Jan 5, 2025
Merged

miscellaneous small changes #2090

merged 8 commits into from
Jan 5, 2025

Conversation

larskuhtz
Copy link
Contributor

Several small changes that will keep some upcoming larger code reviews more concise:

  • add binary, textual, and JSON encodings for MinerReward
  • improve fix some code comments
  • Add HasChainwebVersion and HasChainId instances for BlockInProgress and NewBlock
  • Generalize atChain to accept HasChainId constraint
  • add putShortByteString and getShortByteString to serialization utils
  • fix indentation of some code in Chainweb.Chainweb
  • add parentHeaderHash and rankedParentHash functions for BlockHeader

@larskuhtz larskuhtz enabled auto-merge January 4, 2025 21:33
@larskuhtz larskuhtz disabled auto-merge January 5, 2025 02:35
@larskuhtz larskuhtz merged commit 73cc88d into master Jan 5, 2025
39 of 41 checks passed
@larskuhtz larskuhtz deleted the lars/misc branch January 5, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundnoble edmundnoble edmundnoble approved these changes

@chessai chessai Awaiting requested review from chessai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larskuhtz @edmundnoble