Add gas quirks to Pact 5 #2092
Merged
Add gas quirks to Pact 5 #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, we'd say "the command with request key X has gas Y". Now we say "the command on chain X with block height H and at index I has gas Y". This makes it possible to test without tying the knot anywhere, because the request key is a hash that includes the version name, and also lets us integrate it into Pact 5 later. Change-Id: Id00000007bbb29b009a2b2e4a0cf36180c8df1a7
We don't have a use for these yet, but this does establish the way they can work in future. Change-Id: Id0000000988f8d89c77367f877e8e103aa2dade6
edmundnoble
force-pushed
the
push-qrrkrmrqnssw
branch
from
27e2377 to
b445c59
Compare
jmcardon
approved these changes
Jan 8, 2025
| -- rs <- txResults | ||
| -- liftIO $ print rs | ||
| -- testCurrentBlock quirkedTests | ||
| -- TODO: pact5. |
There was a problem hiding this comment.
Remove this comment? You have quirkSpec in the pact 5 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have a use for these yet, but this does establish the way
they can work in future. Depends on #2091.