SQLite #29
Merged
SQLite #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rsoeldner
commented
Nov 15, 2023
•
rsoeldner
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206050198560810
jmcardon
reviewed
Nov 15, 2023
jmcardon
reviewed
Nov 15, 2023
jmcardon
reviewed
Nov 15, 2023
jmcardon
reviewed
Nov 15, 2023
rsoeldner
force-pushed
the
greg/sqlite
branch
from
0ab62c8 to
a288587
Compare
Signed-off-by: rsoeldner <[email protected]>
jmcardon
reviewed
Dec 15, 2023
jmcardon
reviewed
Dec 15, 2023
| @@ -28,7 +28,8 @@ module Pact.Core.IR.Eval.CEK | |||
| , evalWithStackFrame | |||
| , emitEvent | |||
| , emitCapability | |||
| , guardForModuleCall) where | |||
| , guardForModuleCall | |||
There was a problem hiding this comment.
Is there a place we were missing this? Or is this for testing purposes
There was a problem hiding this comment.
TBH I'm not sure why it's part of this PR. But indeed that export is needed. coreEmitEvent raw builtin uses it. coreEmitEvent is not related to this PR. Confused.
0xd34df00d
approved these changes
Dec 15, 2023
rsoeldner
commented
Dec 17, 2023
| -- | | ||
| -- | A SQLite implementation of the PactDb persistence abstraction. | ||
|
|
||
| -- TODO: Consider using neat-interpolation to clean up the string literals in this module. |
There was a problem hiding this comment.
Personally, I do feel we should aim at minimising dependencies. So-far we use neat-interpolation just for our test suite and I don't think it's required for this work. But I agree, we should have this comment and consider these changes in the future
jmcardon
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.