Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unannotated return type checks to match prod core behavior #41

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Remove unannotated return type checks to match prod core behavior #41

merged 1 commit into from
Dec 13, 2023

Conversation

0xd34df00d
Copy link
Contributor

No description provided.

@jmcardon
Copy link
Member

This definitely needs a test, but i know we're working on them in #38 so no worries

@jmcardon jmcardon merged commit d0dfdb9 into master Dec 13, 2023
3 checks passed
@0xd34df00d 0xd34df00d deleted the gr/match-return-types branch December 13, 2023 16:42
0xd34df00d added a commit that referenced this pull request Dec 13, 2023
@0xd34df00d
Revert "Some tests for unannotated return types in interfaces"
40fb036 
This reverts commit f3d3635.

Allowing unannotated return types follows the prod behavior more
closely, as discussed (and implemented) in #41.
imalsogreg pushed a commit that referenced this pull request Dec 14, 2023
@0xd34df00d @imalsogreg
Revert "Some tests for unannotated return types in interfaces"
f5e9ae0 
This reverts commit f3d3635.

Allowing unannotated return types follows the prod behavior more
closely, as discussed (and implemented) in #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcardon jmcardon jmcardon approved these changes

@rsoeldner rsoeldner Awaiting requested review from rsoeldner rsoeldner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xd34df00d @jmcardon