Updated expect-failure docs #1058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expect-failure` didn't fully describe how it worked: It checks if err is contained in the thrown error. So I added that. It's nice to have that info in there.
|
Hi, this needs to be added to the native definition itself, not to the docs which are auto-generated: https://github.com/kadena-io/pact/blob/master/src/Pact/Repl/Lib.hs#L170-L176 |
|
Is this something you want to attempt, @Luzzotica? Or shall I close this and reference it in a follow up. |
|
I can try to figure it out. Give me until the end of the week. :)On Nov 16, 2022, at 2:56 PM, Emily Pillmore ***@***.***> wrote:
Is this something you want to attempt, @Luzzotica? Or shall I close this and reference it in a follow up.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect-failuredidn't fully describe how it worked: It checks if err is contained in the thrown error. So I added that. It's nice to have that info in there.