Fix unexpected free variable in FV #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsoeldner
changed the title
rsoeldner
commented
Jul 23, 2023
| @@ -1938,6 +1922,7 @@ runTranslation modName funName info caps pactArgs body checkType = do | |||
| CheckDefconst | |||
| -> error "invariant violation: this cannot be a constant" | |||
| _ <- extendPath -- form final edge for any remaining events | |||
| expectNoFreeVars | |||
There was a problem hiding this comment.
final check that no free vars are dangling
rsoeldner
changed the title
|
@rsoeldner Where is the test to show what behavior this is actually impacting? |
|
@jwiegley ... missed pushing them |
jwiegley
approved these changes
Jul 25, 2023
imalsogreg
reviewed
Jul 26, 2023
| (fold (child) true [[1]])) | ||
| |] | ||
|
|
||
| expectVerified [text| |
There was a problem hiding this comment.
Does this test need any properties? Or an assertion that (= (parent) [[false]]) or similar?
There was a problem hiding this comment.
No, it would fail even without a property annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1250
This PR makes use of a stack of free variables to allow for nested application of higher-order functions such as
foldormap.PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: