Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nix files for ghc-9.6 #1255

Merged
merged 1 commit into from
Jul 19, 2023
Merged

update nix files for ghc-9.6 #1255

merged 1 commit into from
Jul 19, 2023

Conversation

imalsogreg
Copy link
Contributor

Bumps to the nix files (and comments in cabal.project that support nix), for ghc-9.6.

[greghale@michelangelo:~/code/pact]$ nix develop
[greghale@michelangelo:~/code/pact]$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.6.2
Check MacOS NixOS
ghc fetched from cache
pact repl works

PR checklist:

  • [n/a] Test coverage for the proposed changes
  • [n/a] PR description contains example output from repl interaction or a snippet from unit test output
  • [n/a] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • [n/a] Any changes that could be relevant to users have been recorded in the changelog
  • [n/a] In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • [n/a] Confirm replay/back compat: pact's nix files aren't used downstream in replay
  • [n/a] Benchmark regressions: pact's nix files aren't used for official releases, where regressions would be a problem
  • [n/a] (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact. pact's nix files aren't used by chainweb

@@ -2,7 +2,7 @@
description = "Kadena's Pact smart contract language";

inputs = {
nixpkgs.url = "github:NixOS/nixpkgs?rev=4d2b37a84fad1091b9de401eb450aae66f1a741e";
nixpkgs.follows = "haskellNix/nixpkgs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imalsogreg imalsogreg merged commit 570d148 into master Jul 19, 2023
10 checks passed
@imalsogreg imalsogreg deleted the greg/nix-ghc-9.6 branch July 19, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants