Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mtl >=2.3 #1261

Merged
merged 1 commit into from
Jul 26, 2023
Merged

use mtl >=2.3 #1261

merged 1 commit into from
Jul 26, 2023

Conversation

larskuhtz
Copy link
Contributor

Switch to mtl >=2.3. This is a prerequisite for supporting sbv-10.

The code changes as well as the update of the sbv pin are due to the following changes:

  • mtl modules do not re-export Control.Monad any more
  • Either is not an instance of Alternative any more

[to the best of my knowledge nothing of the following applies to this PR]

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@larskuhtz larskuhtz merged commit 0e1fe56 into master Jul 26, 2023
12 checks passed
@larskuhtz larskuhtz deleted the lars/mtl-2.3 branch July 26, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants