Add data corruption due to insufficient memory allocation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadenzipfel
requested changes
Jun 7, 2024
There was a problem hiding this comment.
I'm gonna come back to this, but initial thoughts are that it's highly specific to the provided example. It might even make the most sense to have the issue be generalized to just "Data Corruption" and can encompass various different ways this can occur including memory, storage, etc..
| @@ -0,0 +1,175 @@ | |||
| # Memory Corruption Due to Insufficient Memory Allocation | |||
|
|
|||
| Memory corruption occurs when a program writes outside the bounds of allocated memory, potentially overwriting other important data. | |||
There was a problem hiding this comment.
I think it would be more accurate to say, "Memory corruption can occur..." since it's not the only cause
There was a problem hiding this comment.
fair enough, lemme see if we can generalize this vuln type as suggested
…arity and giving a general description rather than the specific one to the ENS audit
indeqs
changed the title
…md to data-corruption-due-to-insufficient-memory-allocation.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Checklist
Describe the changes you've made:
This PR adds a memory corruption vulnerability stemming from insufficient memory allocation when using YUL for memory allocation
Type of change
Select the appropriate checkbox: