Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-Render re-write feature tries to re-write added messages of non existing document #188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

varenytskyi
Copy link

Issue:

There is still a case when fast-render re-writes added messages of previously removed documents. As result meteor throws the following error:
fast-render example 2017-02-24 16-38-05

Here is an example app where you could try this out: https://github.com/varenytskyi/fast-render-example/tree/master
or see this video

Mostly it happens when document is re-added with another cursor in complex publications


Fix:

The fix is pretty simple. Since meteor buffers ddp messages we have to be sure that there is no removed message in internal meteor queue before re-writing added message of the same document.

There is a branch with patched fast-render in the app I've mentioned above: https://github.com/varenytskyi/fast-render-example/tree/with-patched-fast-render
Here is also a video how patched version works.

@varenytskyi
Copy link
Author

Hi @arunoda,

This is a critical issue which appears even when initial loading is completed.

It would be great to see this issue patched. Thanks!

@varenytskyi
Copy link
Author

@theosp No, I didn't.
I clearly explain above what kind of issue this changes fix.

Nice to see your new PR as far as the issue you've mentioned appears as well sometimes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants