Fast-Render re-write feature tries to re-write added
messages of non existing document
#188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There is still a case when fast-render re-writes
added
messages of previously removed documents. As result meteor throws the following error:Here is an example app where you could try this out: https://github.com/varenytskyi/fast-render-example/tree/master
or see this video
Mostly it happens when document is re-added with another cursor in complex publications
Fix:
The fix is pretty simple. Since meteor buffers ddp messages we have to be sure that there is no
removed
message in internal meteor queue before re-writingadded
message of the same document.There is a branch with patched fast-render in the app I've mentioned above: https://github.com/varenytskyi/fast-render-example/tree/with-patched-fast-render
Here is also a video how patched version works.