Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where root is 'react-root' even though using it 'withOptions' #23

Closed
wants to merge 1 commit into from

Conversation

HenriBeck
Copy link

When you create a new mounter with withOptions and try to mount something without the regions argument, it would use the options from withOptions as the regions and not as the options

This will fix #10

…t without regions would cause the options to not be used

Updated tests for withOptions
@HenriBeck HenriBeck closed this Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root is still react-root using withOptions()
1 participant