Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor stuff #107

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Fix minor stuff #107

merged 5 commits into from
Feb 17, 2024

Conversation

Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes type/bug Something isn't working type/refactor Refactoring task labels Feb 5, 2024
@Haarolean Haarolean self-assigned this Feb 5, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 5, 2024
@Haarolean Haarolean removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Feb 5, 2024
@Haarolean Haarolean merged commit e280c8e into main Feb 17, 2024
51 of 55 checks passed
@Haarolean Haarolean deleted the enh/minor_stuff branch February 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working type/enhancement En enhancement/improvement to an already existing feature type/refactor Refactoring task
Projects
None yet
4 participants