Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Refactor NewTable Types #141

Merged
merged 2 commits into from
Feb 19, 2024
Merged

FE: Refactor NewTable Types #141

merged 2 commits into from
Feb 19, 2024

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Feb 17, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fix the New Table Typescript any type and made it generic.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there Mgrdich! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Mgrdich Mgrdich added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes labels Feb 17, 2024
@Haarolean Haarolean added type/refactor Refactoring task and removed type/enhancement En enhancement/improvement to an already existing feature labels Feb 18, 2024
@Haarolean Haarolean added this to the 1.0 milestone Feb 18, 2024
@Haarolean Haarolean requested a review from Leshe4ka February 18, 2024 06:59
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Feb 18, 2024
@Haarolean Haarolean changed the title Fix NewTable Types FE: Refactor NewTable Types Feb 18, 2024
@Mgrdich Mgrdich force-pushed the table-typescript-changes branch from e2ccaa7 to 8e4a65b Compare February 18, 2024 13:11
@Mgrdich Mgrdich merged commit 32d2a58 into main Feb 19, 2024
5 of 8 checks passed
@Mgrdich Mgrdich deleted the table-typescript-changes branch February 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants