Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Split big chunks #210

Merged
merged 6 commits into from
Mar 30, 2024
Merged

FE: Split big chunks #210

merged 6 commits into from
Mar 30, 2024

Conversation

Nilumilak
Copy link
Member

  • Added lazy imports

resolves #192

@Nilumilak
FE: Split big chunks
4650280 
- Added lazy imports

resolves #192
@Nilumilak Nilumilak added scope/frontend Related to frontend changes type/chore Boring stuff, could be refactoring or tech debt status/triage/completed Automatic triage completed labels Mar 14, 2024
@Nilumilak Nilumilak requested a review from Mgrdich March 14, 2024 07:37
@Nilumilak Nilumilak self-assigned this Mar 14, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress and removed status/triage Issues pending maintainers triage labels Mar 14, 2024
@Mgrdich
Copy link
Contributor

Mgrdich commented Mar 14, 2024

i think it broke some tests

@Nilumilak
FE: Split big chunks
926735e 
fix tests

resolves #192
@Nilumilak
Copy link
Member Author

i think it broke some tests

I fixed that, although I'm not sure about the solution

@Haarolean Haarolean modified the milestones: 1.1, 2.0 Mar 18, 2024
@Nilumilak Nilumilak requested a review from a team as a code owner March 21, 2024 23:58
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Mar 25, 2024
@Nilumilak
FE: Split big chunks
4c96d12 
fix tests

resolves #192
@Nilumilak
FE: Split big chunks
0b81c33 
fix tests

resolves #192
@Nilumilak Nilumilak requested a review from Mgrdich March 28, 2024 13:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Haarolean Haarolean merged commit 78d308a into main Mar 30, 2024
9 checks passed
@Haarolean Haarolean deleted the fix/split_big_chunks branch March 30, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mgrdich Mgrdich Mgrdich approved these changes

Assignees

@Nilumilak Nilumilak

Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Split big chunks
3 participants
@Nilumilak @Mgrdich @Haarolean