Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Fix user matching in OauthAuthorityExtractor #298

Merged
merged 3 commits into from
Apr 19, 2024
Merged

BE: Fix user matching in OauthAuthorityExtractor #298

merged 3 commits into from
Apr 19, 2024

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Apr 15, 2024 •
edited
Loading

  • Fixed a bug where username role matching wasn't performed if the roles field was missing
  • Refactoring, additional logging

@Haarolean Haarolean self-assigned this Apr 15, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 15, 2024
@Haarolean Haarolean marked this pull request as ready for review April 15, 2024 17:07
@Haarolean Haarolean requested a review from a team as a code owner April 15, 2024 17:07
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt labels Apr 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Haarolean Haarolean added this to the 1.1 milestone Apr 19, 2024
@Haarolean Haarolean added type/bug Something isn't working and removed type/enhancement En enhancement/improvement to an already existing feature labels Apr 19, 2024
@Haarolean Haarolean changed the title BE: Refactor OauthAuthorityExtractor and improve logging BE: Fix user matching in OauthAuthorityExtractor Apr 19, 2024
@Haarolean Haarolean merged commit 21da50a into main Apr 19, 2024
21 of 22 checks passed
@Haarolean Haarolean deleted the misc/oauth_extractor branch April 19, 2024 10:22
@Haarolean Haarolean removed the type/chore Boring stuff, could be refactoring or tech debt label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Haarolean Haarolean

Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
No open projects
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Haarolean