Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Impl custom authentication page #635

Merged
merged 10 commits into from
Dec 28, 2024
Merged

BE: Impl custom authentication page #635

merged 10 commits into from
Dec 28, 2024

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Oct 25, 2024 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Prerequisite for #72

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/auth App authentication related issues labels Oct 25, 2024
@Haarolean Haarolean self-assigned this Oct 25, 2024
@Haarolean Haarolean requested a review from a team as a code owner October 25, 2024 22:10
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 25, 2024
@Haarolean
Merge remote-tracking branch 'origin/main' into auth_page_be
7b6cf2e 
# Conflicts:
#	api/src/main/java/io/kafbat/ui/service/ApplicationInfoService.java
@Haarolean Haarolean linked an issue Oct 25, 2024 that may be closed by this pull request
Auth: Impl an authentication page #72
Closed
@Haarolean Haarolean requested a review from a team as a code owner December 23, 2024 15:19
@Haarolean Haarolean changed the base branch from main to auth_page_merge December 28, 2024 04:04
@Haarolean Haarolean merged commit 517502b into auth_page_merge Dec 28, 2024
15 of 17 checks passed
@Haarolean Haarolean deleted the auth_page_be branch December 28, 2024 04:04
Haarolean added a commit that referenced this pull request Dec 28, 2024
@Haarolean @germanosin
BE: Impl custom auth page (#635)
85330e8 
Co-authored-by: German Osin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanosin germanosin germanosin approved these changes

Assignees

@Haarolean Haarolean

Labels
area/auth App authentication related issues scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth: Impl an authentication page
2 participants
@Haarolean @germanosin