Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: FE: migrate to node 22 #748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Infra: FE: migrate to node 22 #748

wants to merge 2 commits into from

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Jan 3, 2025

What changes did you make? (Give an overview)

Node 18 reached end of life in 18 Oct 2023. The latest LTS version of Node is 22.x

See https://endoflife.date/nodejs

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings (e.g. Sonar is happy)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

cute-wild-animals-photos-hardcore-aww-2-63345025740e4__700

@yeikel yeikel requested review from a team as code owners January 3, 2025 20:51
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 3, 2025
@@ -103,7 +103,7 @@
"whatwg-fetch": "3.6.20"
},
"engines": {
"node": "18.17.1",
"node": ">=22.12.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm not quite familiar with how this works, won't we get any potential issues if versions like 23.x will be used one day?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right in your suspicions, thank you!

I updated it ba033d6 to use the ^ to only allow the current major version:

Greater than or equal to 22.12.0
Less than 23.0.0 (the next major version)

Please note that in our current configuration, we are not strictly enforcing this so it only produces a log message:

 WARN  Unsupported engine: wanted: {"node":"^22.12.0"} (current: {"node":"v23.5.0","pnpm":"9.15.3"})
Lockfile is up to date, resolution step is skipped

If the intention was to block installation, we would need to use Strict engine checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants