Add pid file support #543
Open
Add pid file support #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zachomedia . Could you put this next to
|
|
@kahing Thanks, I've made the requested change. |
feat(sparse): Allow for sparse file uploads
Chore: Bump repo to latest forked commit
Add dockerfile and workflow
chore(documentation): point out meta-fuse-csi-plugin
* update(security): Ubuntu to alpine, update go pkgs The Ubuntu image had some vulnerablities and the easiest way to fix it was to switch to alpine. This results in a smaller image with fewer attack surfaces. Since this is a small image with a single application it makes sense to use a small base. I've also updated some of the go packages, see the diff. * update(security): Ubuntu to alpine, update go pkgs The Ubuntu image had some vulnerablities and the easiest way to fix it was to switch to alpine. This results in a smaller image with fewer attack surfaces. Since this is a small image with a single application it makes sense to use a small base. I've also updated some of the go packages, see the diff. * update(Dockerfile): add bash * update(Dockerfile): add missing packages * update(Dockerfile): modify symlink * add apk upgrade to fix alpine cves Some new CVEs have popped up but adding apk update && apk upgrade to the Dockerfile ensures we are using the latest and most secure packages. goofys (alpine 3.20.2) Total: 2 (UNKNOWN: 0, LOW: 0, MEDIUM: 2, HIGH: 0, CRITICAL: 0) ┌────────────┬───────────────┬──────────┬────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Status │ Installed Version │ Fixed Version │ Title │ ├────────────┼───────────────┼──────────┼────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────┤ │ libcrypto3 │ CVE-2024-6119 │ MEDIUM │ fixed │ 3.3.1-r3 │ 3.3.2-r0 │ Issue summary: Applications performing certificate name │ │ │ │ │ │ │ │ checks (e.g., ... │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2024-6119 │ ├────────────┤ │ │ │ │ │ │ │ libssl3 │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ └────────────┴───────────────┴──────────┴────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────┘ * update(Dockerfile): pin alpine image version to 3.20.3 I've also reverted the script to use bash instead of sh since we installed bash for compatibility reasons. I've reverted the golang builder containers to use version 1.20.7 since we don't want to introduce new unknown issues. --------- Co-authored-by: Bryan Paget <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for writing a PID file. This lets us clean up our Kubernetes flexvol mounts (https://github.com/StatCan/s3-fuse-flex-volume) since we can track the pid of the goofys instance we launch.