Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style tweak for auto api #2057

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: style tweak for auto api #2057

merged 1 commit into from
Nov 8, 2024

Conversation

kai687
Copy link
Owner

@kai687 kai687 commented Nov 8, 2024

Fix display issues for type hints in API documentation with sphinx-autoapi.
To be able to better check this, this PR also adds a small mock Python module,
with a demo page for documenting it.

Styling is not 100% perfect, as the page now includes double lines (one for the heading 'Module contents' and one for the function signature). But still better than before.

@vict0rsch I hope it's ok that I took your function from issue #2056 and put it as an example in these docs.

Fixes #2056.

@kai687 kai687 marked this pull request as ready for review November 8, 2024 10:14
@kai687 kai687 added the bug Something isn't working label Nov 8, 2024
@kai687 kai687 self-assigned this Nov 8, 2024
@kai687
Copy link
Owner Author

kai687 commented Nov 8, 2024

Deploy preview (what happened to the automatic comment?): https://deploy-preview-2057--sphinxawesome-theme.netlify.app/

Repository owner deleted a comment Nov 8, 2024
@vict0rsch
Copy link
Contributor

LGTM thanks a lot for your promptness!

@kai687 kai687 merged commit 01d45eb into main Nov 8, 2024
6 checks passed
@kai687 kai687 deleted the fix/autoapi branch November 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hints rendering issue
2 participants