Allow multiple fit runs #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…report-average-and-range' into 158-allow-multiple-fit-runs-and-report-average-and-range
nkaenzig
reviewed
Feb 27, 2024
src/eva/interface/interface.py
Outdated
| if data.datasets.test is not None: | ||
| trainer.test(datamodule=data) | ||
| for run_id in range(n_runs): | ||
| trainer_run = copy.deepcopy(trainer) |
There was a problem hiding this comment.
Copying the trainer and model for each run could be resource-intensive, especially for heavy models. Not sure if there is a better way to do this?
There was a problem hiding this comment.
haven't seen another safe way yet. Let me know if you have a simple idea, otherwise lets open another issue for it
There was a problem hiding this comment.
maybe @ioangatop has another idea. elsewise I'd say let's leave it as is.
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
nkaenzig
reviewed
Feb 27, 2024
…ge-and-range # Conflicts: # src/eva/callbacks/writers/embeddings.py # src/eva/interface/interface.py
nkaenzig
reviewed
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #158
Trainer,CSVLoggerandTensorBoardLoggerto add log_dir-setter_adapt_log_dirsmethod to interface to set the dir for logger, trainer, callback after 'evaluation_id' is createdn_runstimesto test, run
and check the results in logs/dino_vits16/patch_camelyon/<evaluation_id>