Add the missing "v" in front of k3s version #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and refactor steps Fixes: #3167 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Feb 4, 2025
jimmykarily
force-pushed
the
fix-arm-artifact-names
branch
from
a7186a8 to
1236e90
Compare
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
fix-arm-artifact-names
branch
from
1236e90 to
105c80b
Compare
jimmykarily
commented
Feb 4, 2025
| SOFTWARE_VERSION="v$SOFTWARE_VERSION" | ||
| fi | ||
|
|
||
| IMAGE_REF=$(SOFTWARE_VERSION=${SOFTWARE_VERSION} SOFTWARE_VERSION_PREFIX=k3s FLAVOR=${{ inputs.flavor }} FLAVOR_RELEASE="${{ inputs.flavor_release }}" MODEL=${{ inputs.model }} TARGETARCH=arm64 VARIANT=${{ inputs.variant }} REGISTRY_AND_ORG="${{ env.REGISTRY }}" RELEASE=${{ env.RELEASE }} kairos-agent versioneer container-artifact-name) |
There was a problem hiding this comment.
RELEASE=${{ env.RELEASE }} is redundant (env is already set) but better put it there to make it clear what value is being used?
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
fix-arm-artifact-names
branch
from
9523688 to
7bdf705
Compare
Signed-off-by: Dimitris Karakasilis <[email protected]>
mauromorales
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and refactor steps
Fixes: #3167
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #