3166 aws cleanup #3169
Merged
3166 aws cleanup #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
3166-aws-cleanup
branch
7 times, most recently
from
0b4f8d8 to
47093ce
Compare
Fixes #3166 Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
3166-aws-cleanup
branch
from
47093ce to
79c9538
Compare
Itxaka
approved these changes
Feb 7, 2025
Signed-off-by: Dimitris Karakasilis <[email protected]>
because file cannot be accessed with absolute path and we can't point shellcheck to the correct one (because we run checks in a container with mounted volumes) Signed-off-by: Dimitris Karakasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #