Consider the if key in the sizeof calculations. Probably resolve #927

kaitai-io · Mar 8, 2024 · 4346a1f · 4346a1f
1 parent db4a1ad
commit 4346a1f
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/shared/src/main/scala/io/kaitai/struct/precompile/CalculateSeqSizes.scala b/shared/src/main/scala/io/kaitai/struct/precompile/CalculateSeqSizes.scala
@@ -95,7 +95,23 @@ object CalculateSeqSizes {
     var seqPos: Option[Int] = Some(0)
     curClass.seq.foreach { attr =>
       val sizeElement = dataTypeBitsSize(attr.dataType)
-      val sizeContainer = sizeMultiply(sizeElement, attr.cond.repeat, attr.path)
+      val size = sizeMultiply(sizeElement, attr.cond.repeat, attr.path)
+      val sizeContainer = attr.cond.ifExpr match {
+        case Some(expr) => expr.evaluateBoolConst match {
+          case Some(true) => {
+            //TODO: add user visible warning
+            Log.seqSizes.warn(() => s"${attr.path}: condition is always `true`")
+            size
+          }
+          case Some(false) => {
+            //TODO: add user visible warning
+            Log.seqSizes.warn(() => s"${attr.path}: condition is always `false`")
+            FixedSized(0)
+          }
+          case None => DynamicSized
+        }
+        case None => size
+      }
 
       op(attr, seqPos, sizeElement, sizeContainer)