Skip to content

Commit

Permalink
METHOD_PRECEDENCE: adjust to new 10x range as well
Browse files Browse the repository at this point in the history
  • Loading branch information
@GreyCat
GreyCat committed Mar 25, 2024
1 parent d105f21 commit 4fdf4c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shared/src/main/scala/io/kaitai/struct/translators/CommonMethods.scala
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ abstract trait CommonMethods[T] extends TypeDetector {
* - if `obj` is complex (like an expression `a + b`), then this will ensure framing as
* `(a + b).method(args)`.
*/
val METHOD_PRECEDENCE = 99
val METHOD_PRECEDENCE = 999

/**
* Translates a certain attribute call (as in `foo.bar`) into a rendition
Expand Down

2 comments on commit 4fdf4c0

@generalmimon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't help but comment that this confirms my hunch that these magical numbers in various places are not very good for maintainability (#277 (comment)). It's an error-prone approach.

@GreyCat
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yeah, completely agree. Let me think on how to approach it better.

Please sign in to comment.