fixed instance caching logic

kaitai-io · Nov 14, 2021 · 9878485 · 9878485
1 parent 2d53160
commit 9878485
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/shared/src/main/scala/io/kaitai/struct/NimClassCompiler.scala b/shared/src/main/scala/io/kaitai/struct/NimClassCompiler.scala
@@ -106,7 +106,7 @@ class NimClassCompiler(
         lang.attrParse(pi, instName, endian)
     }
 
-    lang.instanceCheckCacheAndReturn(instName, dataType)
+    lang.instanceReturn(instName, dataType)
     lang.instanceFooter
   }
 

diff --git a/shared/src/main/scala/io/kaitai/struct/languages/NimCompiler.scala b/shared/src/main/scala/io/kaitai/struct/languages/NimCompiler.scala
@@ -224,12 +224,9 @@ class NimCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     handleAssignmentSimple(instName, cast)
   }
   override def instanceCheckCacheAndReturn(instName: InstanceIdentifier, dataType: DataType): Unit = {
-    //out.puts(s"if not ${privateMemberName(instanceFlagIdentifier(instName))}:")
-    val flag = instanceFlagIdentifier(instName)
-    out.puts(s"if not this.$flag:")
+    out.puts(s"if this.${instanceFlagIdentifier(instName)}:")
     out.inc
-    out.puts(s"this.$flag = true")
-    instanceReturn(instName, dataType)
+    out.puts(s"return ${privateMemberName(instName)}")
     out.dec
   }
   override def instanceHeader(className: List[String], instName: InstanceIdentifier, dataType: DataType, isNullable: Boolean): Unit = {
@@ -241,6 +238,7 @@ class NimCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts
   }
   override def instanceReturn(instName: InstanceIdentifier, attrType: DataType): Unit = {
+    out.puts(s"this.${instanceFlagIdentifier(instName)} = true")
     out.puts(s"return ${privateMemberName(instName)}")
   }
   // def normalIO: String = ???