Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repeat-expr and repeat-until keys without a repeat key #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Dec 11, 2021

Should be merged together with changes in tests: kaitai-io/kaitai_struct_tests#94

Fixes kaitai-io/kaitai_struct#776

@KOLANICH
Copy link

Why not

repeat:
  expr: 10

instead?

@Mingun
Copy link
Contributor Author

Mingun commented Dec 18, 2021

The discussion about possible changes was so long ago that I completely forgot about this solution. Anyway, implementing completely new solution requires a bit more time and this change is simple and backward-compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow "repeat-expr" and "repeat-until" keys without "repeat" key
2 participants