CanonicalizeEncodingNames: fix locale-sensitive toUpperCase

[generalmimon]

Avoid the problem with the Turkish locale that we have encountered in the past, see kaitai-io/kaitai_struct#708.

[generalmimon]

Unfortunately, this only tests the case conversion directly in CanonicalizeEncodingNames.canonicalizeName:

kaitai_struct_compiler/shared/src/main/scala/io/kaitai/struct/precompile/CanonicalizeEncodingNames.scala

Line 52 in 4ddd3c7

aliasToCanonical.get(Platform.toUpperLocaleInsensitive(original)) match {

Meaning that these occurrences are untested:

kaitai_struct_compiler/shared/src/main/scala/io/kaitai/struct/precompile/CanonicalizeEncodingNames.scala

Lines 67 to 71 in 4ddd3c7

	private val aliasToCanonical: Map[String, String] =
	EncodingList.canonicalToAlias.flatMap { case (canonical, aliases) =>
	aliases.map(alias => (Platform.toUpperLocaleInsensitive(alias), canonical))
	} ++
	EncodingList.canonicalToAlias.keys.map(x => Platform.toUpperLocaleInsensitive(x) -> x)

I presume this aliasToCanonical initialization runs at the time the object CanonicalizeEncodingNames is loaded, so it's probably not as easy to change the default locale & re-run it dynamically as I did here with canonicalizeName. Perhaps there's a way to do that using ClassLoader or something similar, but I have no idea (maybe it's not worth the complexity).

[GreyCat]

Yeah, I'm leaning towards it doesn't worth the complexity for the test. It looks like it works if tested manually, so seems to be good to go.

[GreyCat]

Maybe worth adding this remark as a comment to the test implementation, though.