Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scala 2.13 #266

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Upgrade to Scala 2.13 #266

merged 4 commits into from
Feb 29, 2024

Conversation

GreyCat
Copy link
Member

@GreyCat GreyCat commented Feb 29, 2024

@GreyCat
Copy link
Member Author

GreyCat commented Feb 29, 2024

Previous master build results:

[info] Total number of tests run: 1261
[info] Suites: completed 14, aborted 0
[info] Tests: succeeded 1200, failed 61, canceled 0, ignored 0, pending 0
[info] *** 61 TESTS FAILED ***
[error] Failed tests:
[error] 	io.kaitai.struct.translators.TranslatorSpec
[error] 	io.kaitai.struct.translators.TypeDetector$Test
[error] 	io.kaitai.struct.ErrorMessagesSpec

This build after Scala 2.13 upgrade and some extra fixes:

[info] Total number of tests run: 1261
[info] Suites: completed 14, aborted 0
[info] Tests: succeeded 1200, failed 61, canceled 0, ignored 0, pending 0
[info] *** 61 TESTS FAILED ***
[error] Failed tests:
[error] 	io.kaitai.struct.translators.TranslatorSpec
[error] 	io.kaitai.struct.translators.TypeDetector$Test
[error] 	io.kaitai.struct.ErrorMessagesSpec

Looks like we're maintaining status quo and should not make situation worse.

@GreyCat GreyCat merged commit 8be2e2e into master Feb 29, 2024
1 of 5 checks passed
@GreyCat GreyCat deleted the scala_2.13 branch February 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant