Fix string pattern tests #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
[info] - lua:f"abc{1}%def" *** FAILED ***
[info] ""abc" [.. tostring(1) ..] "%def"" was not equal to ""abc" [+ tostring(1) +] "%def"" (TranslatorSpec.scala:686)
[info] Analysis:
[info] ""abc" [.. tostring(1) ..] "%def"" -> ""abc" [+ tostring(1) +] "%def""
Affected languages:
- C# (also usage of Convert.ToString() was replaced by ordinal .ToString() in the same commit)
- Java
- JavaScript
- Ruby
Fixes
[info] - csharp:f"abc{1}%def" *** FAILED ***
[info] ""abc" + [(1).ToString(]) + "%def"" was not equal to ""abc" + [Convert.ToString((long) (1), 10]) + "%def"" (TranslatorSpec.scala:686)
[info] Analysis:
[info] ""abc" + [(1).ToString(]) + "%def"" -> ""abc" + [Convert.ToString((long) (1), 10]) + "%def""
[info] - java:f"abc{1}%def" *** FAILED ***
[info] "...c" + Long.toString(1[]) + "%def"" was not equal to "...c" + Long.toString(1[, 10]) + "%def"" (TranslatorSpec.scala:686)
[info] Analysis:
[info] "...c" + Long.toString(1[]) + "%def"" -> "...c" + Long.toString(1[, 10]) + "%def""
[info] - javascript:f"abc{1}%def" *** FAILED ***
[info] "...abc" + (1).toString([]) + "%def"" was not equal to "...abc" + (1).toString([10]) + "%def"" (TranslatorSpec.scala:686)
[info] Analysis:
[info] "...abc" + (1).toString([]) + "%def"" -> "...abc" + (1).toString([10]) + "%def""
[info] - ruby:f"abc{1}%def" *** FAILED ***
[info] ""abc" + 1.to_s[] + "%def"" was not equal to ""abc" + 1.to_s[(10)] + "%def"" (TranslatorSpec.scala:686)
[info] Analysis:
[info] ""abc" + 1.to_s[] + "%def"" -> ""abc" + 1.to_s[(10)] + "%def""
Mingun
force-pushed
the
fix-string-pattern-tests
branch
from
bfff572 to
23de295
Compare
|
Implemented in 324f658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following errors:
One of it is using wrong concatenation operator for Lua -- is should be
.., not+.The others is a change in to_string translation, explicit base 10 was removed in 7be4a2b.