Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate parent for types that does not used in the current spec #280

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Calculate parent for types that does not used in the current spec #280

merged 5 commits into from
Apr 15, 2024

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Mar 17, 2024 •
edited
Loading

Fixes kaitai-io/kaitai_struct#961

I have not decided yet, how to test that, so draft for now

@Mingun Mingun force-pushed the fix-parent-calculation branch from 7a50a84 to 38b2592 Compare March 17, 2024 07:26
@Mingun Mingun marked this pull request as ready for review March 17, 2024 07:55
@Mingun Mingun marked this pull request as draft March 17, 2024 07:57
@generalmimon generalmimon force-pushed the fix-parent-calculation branch from 38b2592 to aa58a1a Compare April 15, 2024 21:19
@generalmimon generalmimon marked this pull request as ready for review April 15, 2024 21:19
generalmimon
generalmimon approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@generalmimon generalmimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mingun Thanks!

@generalmimon
Copy link
Member

I have not decided yet, how to test that

I added a new formats_err test called nav_parent_multi_one_unused (see kaitai-io/kaitai_struct_tests@ede1105).

@generalmimon generalmimon merged commit 2191070 into kaitai-io:master Apr 15, 2024
1 of 4 checks passed
@Mingun
Copy link
Contributor Author

Mingun commented Apr 16, 2024 •
edited
Loading

Thanks. I think, it also need to add explicit test for _parent: false case as well, which should compiled successfully
Although such test already exists -- nav_parent_false

@Mingun Mingun deleted the fix-parent-calculation branch April 16, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalmimon generalmimon generalmimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java: incompatible types compile error when type that is reused is used in a type that is unreachable
2 participants
@Mingun @generalmimon