GoCompiler: add kaitai.Struct interface support #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyCat
force-pushed
the
go_kaitai_struct
branch
from
42242cb to
bcf8724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for common interface kaitai.Struct in Go, akin to other KaitaiStruct ancestor classes (e.g. KaitaiStruct in Java).
Given that Go does not have inheritance, it provides the interface + makes sure that every single type we generate carries over this method:
This does not change the status quo that for all internal communications KS expressions still use
._io, not.IO_(). That one we can address later.To be merged after kaitai-io/kaitai_struct_go_runtime#30
Test check
Totals: 195 ran, 179 passed, 16 failed
SUMMARY: {"kst"=>183, "passed"=>179, "failed"=>16}
Comparison with previous: (no changes)