Fix incorrect encoding literals -- escape them #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalmimon
reviewed
Jul 9, 2024
shared/src/main/scala/io/kaitai/struct/translators/GoTranslator.scala
Outdated
Show resolved
Hide resolved
C++: add a method to translator to get the raw string literal instead of std::string object Fixes the following KST tests: - str_encodings_escaping_enc - str_encodings_escaping_to_s
Mingun
force-pushed
the
fix-encoding-literals
branch
from
bd416c6 to
7eb8775
Compare
Rust support is largely reworked in kaitai-io#250 and touching it here would just create conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to C++ it was not possible to call
doStringLiteralinBaseTranslator, because in C++ this method returnsstd::stringobject instead of a"..."literal.Fixes the following KST tests: