replaced struct.unpack with struct.Struct().unpack #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've ran the simple PCAP-based benchmark.
The overall effect is ~2%, and is comparable to the margin of error (which is also about 1-2%). But 2% is still good, I guess ;) |
GreyCat
reviewed
Mar 12, 2018
| @@ -1,5 +1,6 @@ | |||
| import itertools | |||
| import sys | |||
| import struct | |||
| from struct import unpack | |||
There was a problem hiding this comment.
We can probably remove this line now.
|
I made same upgrade to Construct, and the speedup was also within margin of error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #21 . I ran the tests, but leave the benchmarks to you. I am having problems with benchmarks/build-formats.