-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Stream and Struct traits into modules #2
Conversation
9e7fbef
to
9d37877
Compare
@gushromp Thanks for your contribution! However, note that this Rust runtime is currently very experimental and there's no real compiler that generates output that would make use of it. If you want to pick up Rust target development, you're more than welcome to join in with ideas & code at kaitai-io/kaitai_struct#22. I wonder if @LogicAndTrick would review this PR? |
I'm not sure about splitting each individual trait into its own module, at the very most I would add them both into one module called |
@GreyCat Thanks! I've looked a bit into the issues that @LogicAndTrick has bumped into (with the references to the parent structures), and I think I have a vague idea on how to circumvent them but such a hierarchy is not pretty to implement in Rust (involves using Rc<RefCell<T>> everywhere). @LogicAndTrick You're right, I now used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, I think now this looks okay from my end. I'm fine with merging this in.
Thanks, everybody! |
No description provided.