-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serialization tests when generating ci.json
#100
Conversation
Works only in Python so far. I took the path of least resistance, which turned out to be having separate targets The test names in {
"$meta": {
"lang": "python-write",
"timestamp": "2023-07-31T10:02:40Z"
},
"BcdUserTypeBe.ReadWriteRoundtrip": {
"status": "passed",
"elapsed": 0.008,
"is_kst": true
},
"BcdUserTypeLe.ReadWriteRoundtrip": {
"status": "passed",
"elapsed": 0.0,
"is_kst": true
},
"BitsByteAligned.ReadWriteRoundtrip": {
"status": "passed",
"elapsed": 0.0,
"is_kst": true
}, KST adoption reporting is implemented too - if the test class is included in the |
59d4282
to
4e0c5ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, so looks good to me!
Potentially I can outline 2 larger avenues of exploration:
-
How we want to store/present tests for reading and writing parts altogether — e.g. for now "spec" + "specwrite" and "python" + "python-write" seems to be ok, but generally moving forward I really think we want to have them as first class citizens on the same level.
-
Potentially looking into reworking Python invocation per se to report everything in one XML file (as many other languages do), i.e. https://github.com/xmlrunner/unittest-xml-reporting#reporting-to-a-single-file
4e0c5ed
to
aa79aa8
Compare
I agree that a single XML report would be better, but separate XML files work for now. And note that Java (and maybe other languages, haven't checked) uses separate XML files too. |
@GreyCat I've just added Java support in a similar way. |
See kaitai-io/kaitai_struct#1060 (comment)