Revert "Translator: allow go, but not by default" - Go translator is no worse than others #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no worse than others This reverts commit 0590480.
generalmimon
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks! I've been a little annoyed for a while now that I had to type -t all -t go every time, but not enough to do anything about it.
@GreyCat mentioned that Go is not included in -t all because the KST translator used to crash due to "NotImplemented errors", see #75 (comment).
However, if I try ./spec_kst_to_all -t all --all-specs -f now (with this PR's changes), it reaches all specs up to the last zlib_with_header_78 without problems, even though there are 21 scala.NotImplementedErrors when generating .go specs (20 times due to unimplemented doCast, once due to unimplemented testException). So I agree there is no reason to discriminate against Go anymore.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go translator is not included into
allcategory since 0590480, which is strange. It's implementation not worse that, for example, Construct translator and it actually have more high rating on https://ci.kaitai.io.