Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .gitattributes and .gitignore #84

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

dgelessus
Copy link
Contributor

(see commit messages for details)

These generally should not be tracked in Git - see
kaitai-io/kaitai_struct_compiler#195.
Almost all of them were for tools that are not used in this repo.

# Highlight ksy and kst files as YAML on GitHub
*.kst linguist-language=yaml
*.ksy linguist-language=yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually a good point if we want to start a process registering KSY as legitimate language in GH linguist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! It looks like we meet the requirement of "hundreds of repos" using the language (there are 256 GitHub repos with KSY files in them), so I've opened a PR on the Linguist repo: github-linguist/linguist#4830

*.ksy linguist-language=yaml

# Mark generated files for GitHub
spec/** linguist-generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat hesitating about this one, but, I guess you're right, ultimately, they all should be generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits that touch the spec directory make it sound like all of the files are generated from the corresponding KST files. Are some of the files there not generated? If so, it might be a good idea to document that somewhere.

@GreyCat GreyCat merged commit 5ce43a0 into kaitai-io:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants