Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some broken tests #91

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Dec 4, 2020

It seems that tests not updated synchronously with compiler updates and now some of them broken. This PR fixes some of them.

Additionally I add commit to ignore rust artifacts, generated by rls in VSCode

@Mingun
Copy link
Contributor Author

Mingun commented Dec 17, 2020

@GreyCat, @generalmimon, this one also easy to check -- can you please look?

Copy link
Member

@generalmimon generalmimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@generalmimon generalmimon merged commit 6f3e063 into kaitai-io:master Dec 18, 2020
@Mingun Mingun deleted the fix-broken-tests branch December 18, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants