Serialization #99
Open
Serialization #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalmimon
approved these changes
Jul 31, 2023
This is needed to fix the `aggregate/convert_to_json` crash due to error `Unable to parse classname: "unittest.loader.ModuleImportFailure"` that currently occurs when running ./ci-python on Python 2. When `unittest` automatically imports modules during test discovery and some file cannot be imported (e.g. due to a syntax error), the error is reported under the classname `unittest.loader.ModuleImportFailure`, which obviously doesn't match the `/\.Test([^.]*)$/` pattern expected for normal tests. But in that case we just want to skip prepending the classname and continue, not crash - this is not a fatal error.
... to avoid inaccurracies
See previous commit e92fb33
Avoid unnecessarily compiling both `spec` and `specwrite` suites twice, each time only to run tests from one suite. This means that the compilation should be faster, the compile errors (mostly in generated Java sources) won't be duplicated in the console output, and our CI infrastructure will no longer report them (also) in the wrong suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.