-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base Components #16
Merged
Merged
Base Components #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingkyeongg
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
폴더 구조를 바꾸는건가요?
넵, 저번에 멘토님이 말씀해주셨던 구조로 수정했습니다! |
고생하셨습니다! |
# Conflicts: # .eslintrc.cjs # .gitignore # .storybook/main.ts # package.json # yarn.lock
cla6shade
added a commit
that referenced
this pull request
Oct 4, 2024
* week5/harugi7 (#14) * chore: install emotion * chore: 폴더 구조 수정 * feat: ESLint에 맞춰 CamelCase로 변환 * feat: Container 컴포넌트 구현 * Base component: Grid, Spacing (#17) * chore: emotion 설치 * chore: storybook 설치 * feat: Grid 컴포넌트 가져오기 - storybook 파일 생성 * feat: Spacing 컴포넌트 가져오기 * fix: Grid eslint 에러 해결 - react/require-default-props 비활성화 * fix: storybook 파일 eslint 해제 * fix: Spacing eslint 에러 해결 * style: 함수 내보내기 코드 수정 * fix: height 처리 및 반응형 스타일링 개선 * refactor: export Grid 및 Spacing 모듈 추가 * fix: eslint 에러 수정 - dist 폴더, stories.tsx 파일 검사 제외 * fix: 빌드 에러 fix --------- Co-authored-by: cla6shade <[email protected]> * Base Components (#16) * chore: add support for the css prop * refactor: ignore eslint * refactor: styled 대신 serialized css 사용하도록 수정 * chore: deprecated 패턴과 css prop 관련 eslint 설정 * refactor: index 모듈로 변경 * chore: setup storybook * chore: configure svgr, emotion * chore: add packages * feat: shared components * chore: ignore build info file * feat: avatar * chore: add configuration of the router and query client * refactor: 현재의 폴더 구조에 맞게 컴포넌트 경로 수정 --------- Co-authored-by: harugi7 <[email protected]> Co-authored-by: Lee Minkyeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5주차
만들기로 계획했던 base 컴포넌트를 만들었습니다.
자세한 사용법은 컴포넌트 폴더 내부의
컴포넌트명.stories.tsx
를 참조하시면 됩니다.시간관계상 컴포넌트 사용법에 대한 자세한 설명을 적지 못했던 점 양해 부탁드립니다..
react-query와 react-router-dom에 대한 설정을 마쳤습니다.
페이지별 라우트 설정은 provider/BrowserRouterProvider.tsx를 이 링크에 맞춰 수정해주시면 됩니다.
전역 테마를 hook을 통해 불러올 수 있습니다.
emotion css에 내장된 themeing 기능을 이용하고자 했으나 마이그레이션이 조금 더 급한 일이라 후순위에 위치하기로 했습니다.