Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 6주차 리뷰 반영 및 바뀐 명세에 따라 리팩토링 #38

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

youcastle03
Copy link
Contributor

6주차 리뷰에 관련된 부분과 주석추가, 또한 바뀐 명세에 따라 리팩토링 진행하였습니다.
#37
record, builder패턴 도입, 폴더구조 변경의 내용은 금일 회의후에 적용해야한다 판단하여 이번에는 진행하지 않았습니다

jjh4450
jjh4450 previously approved these changes Oct 13, 2024
Comment on lines -11 to +12
@ExceptionHandler(NotFoundUserException.class)
public ResponseEntity notFoundUserException(NotFoundUserException e){
@ExceptionHandler(UserNotFoundException.class)
public ResponseEntity userNotFoundException(UserNotFoundException e){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peacefullyquietly @humpose 작업 진행시 참고 부탁드립니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+NotFoundException을 abstract화 해서 만들어 놓는건 어떨까요?

public abstract class NotFoundException extends RuntimeException {
    public NotFoundException(String message) {
        super(message);
    }
}
public class UserNotFoundException extends NotFoundException {
    public UserNotFoundException(String message) {
        super(message); // 부모 클래스의 생성자를 호출
    }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@jjh4450 jjh4450 merged commit d16431a into kakao-tech-campus-2nd-step3:weekly/6 Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants